Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmrender-resurrect: cc96ede -> 0.0.8 #71474

Merged
merged 5 commits into from Nov 16, 2019

Conversation

@ashkitten
Copy link
Contributor

ashkitten commented Oct 20, 2019

Motivation for this change

was marked broken, now updated with hzeller/gmrender-resurrect#190 and tested to work. also, added myself as a maintainer because i plan to keep this up to date in the future as i use it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @k0ral

@ashkitten ashkitten force-pushed the ashkitten:update-gmrender-resurrect branch from 380712b to b4fef99 Oct 21, 2019
@ashkitten ashkitten changed the title Update gmrender resurrect gmrender-resurrect: cc96ede -> v0.0.8 Oct 21, 2019
@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Oct 21, 2019

the first release of gmrender-resurrect was just published, so i changed the pull request to reflect that. theoretically, we should be able to follow releases now!

Copy link
Contributor

c0bw3b left a comment

You can replace autoconf+automake with autoreconfHook in nativeBuildInputs too.

Then the explicit definitions of preConfigurePhases and autoconfPhase aren't needed anymore.

pkgs/tools/networking/gmrender-resurrect/default.nix Outdated Show resolved Hide resolved
@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Nov 16, 2019

just incorporated suggestions and refactored the plugin path out to a function which generates it from a list of packages

@ashkitten ashkitten force-pushed the ashkitten:update-gmrender-resurrect branch from a1f613e to dde3b9f Nov 16, 2019
Copy link
Contributor

c0bw3b left a comment

Woah the diff is weird now! Maybe you used another editor and it turned spaces into tabs.
+ inconsistent indentation in your let .. in block
+ why scope fetchpatch? doesn't seem to be used

@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Nov 16, 2019

the let..in block was just one line before, so by adding more things i had to expand it out, thus the massive indentation change that made the diff effectively useless. sorry about that. i don't see any inconsistent indentation, though.

it seems i forgot to remove fetchpatch from before 0.0.8 was released and i was pulling in a patch to get it to compile. i'll remove that.

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 16, 2019

the let..in block was just one line before, so by adding more things i had to expand it out, thus the massive indentation change that made the diff effectively useless. sorry about that. i don't see any inconsistent indentation, though.

Oh ok! No you did nothing wrong then.
GH UI misled my eyes with those bold color blocks.. >;<

@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Nov 16, 2019

apparently there is an option to hide whitespace changes behind the cog icon in the diff ui
image

@c0bw3b c0bw3b changed the title gmrender-resurrect: cc96ede -> v0.0.8 gmrender-resurrect: cc96ede -> 0.0.8 Nov 16, 2019
@c0bw3b
c0bw3b approved these changes Nov 16, 2019
Copy link
Contributor

c0bw3b left a comment

Builds and runs

@c0bw3b c0bw3b merged commit 19b9dd6 into NixOS:master Nov 16, 2019
15 checks passed
15 checks passed
gmrender-resurrect on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
gmrender-resurrect on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.