Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fly: 5.4.1 -> 5.7.0 #71484

Merged
merged 1 commit into from Dec 9, 2019
Merged

fly: 5.4.1 -> 5.7.0 #71484

merged 1 commit into from Dec 9, 2019

Conversation

@purcell
Copy link
Contributor

@purcell purcell commented Oct 21, 2019

Motivation for this change

The fly command line tool warns (or even refuses to run) with newer concourse server versions. The current stable server release is 5.6.0, so this brings fly into sync with it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) n/a
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" n/a
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ivanbrennan

Copy link
Member

@ivanbrennan ivanbrennan left a comment

Thanks for the update!

@purcell
Copy link
Contributor Author

@purcell purcell commented Nov 12, 2019

In the meantime, concourse 5.7.0 is now out.

@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Dec 8, 2019

getting this error:

hash mismatch in fixed-output derivation '/nix/store/lz72r0saxbbccrpy047aas17ybrs6kbf-fly-5.6.0-go-modules':
  wanted: sha256:0v3kskajwyf5c8yzwyficg2a5m54gjq0cxk1d08ix22svf8nb7x8
  got:    sha256:1dvf02z7dg2nas1fvscsrh7fqbqv0ws4hlhw88qv6m1cxba0lrcb
cannot build derivation '/nix/store/5lzwmlkr65zp2gaw2jpd9zx9yf2cgsbs-fly-5.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/aw0pzrhlc61836g4al2nj3v7njrqjqb7-env.drv': 1 dependencies couldn't be built
[1 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/aw0pzrhlc61836g4al2nj3v7njrqjqb7-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71484
1 package failed to build:
fly
@purcell
Copy link
Contributor Author

@purcell purcell commented Dec 9, 2019

getting this error:

Weird.

In any case, since this hadn't been merged yet, I've bumped the version further to the new latest release.

@ofborg ofborg bot requested a review from ivanbrennan Dec 9, 2019
@Lassulus Lassulus changed the title fly: 5.4.1 -> 5.6.0 fly: 5.4.1 -> 5.7.0 Dec 9, 2019
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Dec 9, 2019

now it works. can you squash the commits into one?

@purcell purcell force-pushed the purcell:patch-1 branch from fe14e40 to def5f62 Dec 9, 2019
@purcell
Copy link
Contributor Author

@purcell purcell commented Dec 9, 2019

Done, thx.

@ofborg ofborg bot requested a review from ivanbrennan Dec 9, 2019
Copy link
Contributor

@Lassulus Lassulus left a comment

tested with nix-review

@Lassulus Lassulus merged commit 866424d into NixOS:master Dec 9, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
fly on aarch64-linux Success
Details
fly on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.