Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxsmm: init at 1.13 #71498

Merged
merged 1 commit into from May 23, 2020
Merged

libxsmm: init at 1.13 #71498

merged 1 commit into from May 23, 2020

Conversation

@chessai
Copy link
Member

chessai commented Oct 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @chessai

@chessai chessai force-pushed the chessai:libxsmm-add branch from d9887a9 to bc8c9c4 Oct 21, 2019
@chessai chessai force-pushed the chessai:libxsmm-add branch from 6c83f0f to 2bf18e9 Oct 21, 2019
@chessai chessai changed the title libxsmm: add libxsmm: init at 1.13 Oct 21, 2019

installPhase = ''
runHook preInstall
make install SHELL=${bash}/bin/bash PREFIX=$out

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer Nov 7, 2019

Member

This should use makeFlags = [ "PREFIX=$(out)" ]; instead of overriding installPhase to be more concise. SHELL is provided automatically.

@doronbehar
Copy link
Contributor

doronbehar commented May 23, 2020

I'm closing as OP seems not intent to respond to review requests.

@doronbehar doronbehar closed this May 23, 2020
@chessai chessai reopened this May 23, 2020
@chessai chessai force-pushed the chessai:libxsmm-add branch from 2bf18e9 to 6333819 May 23, 2020
@chessai
Copy link
Member Author

chessai commented May 23, 2020

@doronbehar thanks for the ping! responded to @matthewbauer's review

@matthewbauer matthewbauer merged commit 64f8baf into NixOS:master May 23, 2020
16 checks passed
16 checks passed
libxsmm, libxsmm.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6333819"; rev="6333819c60f3c13c9467efd1410835639d6a8228"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6333819"; rev="6333819c60f3c13c9467efd1410835639d6a8228"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6333819"; rev="6333819c60f3c13c9467efd1410835639d6a8228"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6333819"; rev="6333819c60f3c13c9467efd1410835639d6a8228"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6333819"; rev="6333819c60f3c13c9467efd1410835639d6a8228"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6333819"; rev="6333819c60f3c13c9467efd1410835639d6a8228"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6333819"; rev="6333819c60f3c13c9467efd1410835639d6a8228"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libxsmm, libxsmm.passthru.tests on x86_64-linux Success
Details
@chessai
Copy link
Member Author

chessai commented May 23, 2020

thanks @matthewbauer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.