Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: 3.28.0 backport fix for CVE-2019-16168 #71695

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@d-goldin
Copy link
Contributor

d-goldin commented Oct 22, 2019

Motivation for this change

This is a manually backported patch for a crash induced by a division by
zero. The patch had to be manually adopted to the "amalgamated" source
release.

Related: #70593
Addresses #68583 for 19.09

I'm suggesting this for 19.09 so that we don't have to bump versions.
Fix was manually verified using: https://www.sqlite.org/src/info/e4598ecbdd18bd82945f6029013296690e719a62

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

This is a manually backported patch for a crash induced by a division by
zero. The patch had to be manually adopted to the "amalgamated" source
release.
@d-goldin

This comment has been minimized.

Copy link
Contributor Author

d-goldin commented Oct 31, 2019

@andir: What's your take on this?

@andir

This comment has been minimized.

Copy link
Member

andir commented Nov 1, 2019

Since people don't want the newer sqlite version on 19.09 I'll just merge this in. At least this topic will then be resolved.

@andir andir merged commit 02ad40a into NixOS:release-19.09 Nov 1, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@d-goldin d-goldin deleted the d-goldin:backport_sqlite_fix branch Nov 1, 2019
@d-goldin

This comment has been minimized.

Copy link
Contributor Author

d-goldin commented Nov 1, 2019

@andir: Alright, thanks!

@FRidh FRidh moved this from Needs review to Merged in Staging (stable) Nov 2, 2019
d-goldin added a commit to d-goldin/nixpkgs that referenced this pull request Nov 7, 2019
CVE fix in NixOS#71695 broke this package, as it's an older
version and additionaly disables amalgamation.

The supplied patch is modified minimally to fit this version (slight
line number change for analyze.c).

The fix was verified using
https://www.sqlite.org/src/info/e4598ecbdd18bd82945f6029013296690e719a62
as for the previous fix.
@d-goldin d-goldin mentioned this pull request Nov 7, 2019
5 of 10 tasks complete
d-goldin added a commit to d-goldin/nixpkgs that referenced this pull request Nov 7, 2019
CVE fix in NixOS#71695 broke this package, as it's an older
version and additionaly disables amalgamation.

The supplied patch is modified minimally to fit this version (slight
line number change for analyze.c).

The fix was verified using
https://www.sqlite.org/src/info/e4598ecbdd18bd82945f6029013296690e719a62
as for the previous fix.
d-goldin added a commit to d-goldin/nixpkgs that referenced this pull request Nov 7, 2019
CVE fix in NixOS#71695 broke this package, as it's an older
version and additionaly disables amalgamation.

The supplied patch is modified minimally to fit this version (slight
line number change for analyze.c).

The fix was verified using
https://www.sqlite.org/src/info/e4598ecbdd18bd82945f6029013296690e719a62
as for the previous fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.