Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackage.jsonlines: init at 1.2.0 #71705

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@sondr3
Copy link
Contributor

sondr3 commented Oct 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

jonringer left a comment

tox is for emulating different interpreters, nix already parameterizes this.

pkgs/development/python-modules/jsonlines/default.nix Outdated Show resolved Hide resolved
@sondr3 sondr3 force-pushed the sondr3:python-package/jsonlines-init branch 3 times, most recently from 186d001 to 0822a53 Oct 22, 2019
Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS (python38Packages.pytest is broken on master)
diff LGTM
tests run

[4 built (1 failed), 105 copied (47.0 MiB), 13.8 MiB DL]
error: build of '/nix/store/57d9l07s5yks5anwr9w4nxd859cb8crm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71705
1 package failed to build:
python38Packages.jsonlines

2 package were build:
python27Packages.jsonlines python37Packages.jsonlines
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Oct 22, 2019

please cleanup tox, and then it LGTM

@sondr3 sondr3 force-pushed the sondr3:python-package/jsonlines-init branch from 0822a53 to 415ebe8 Oct 22, 2019
@sondr3

This comment has been minimized.

Copy link
Contributor Author

sondr3 commented Oct 22, 2019

Done 😃

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Oct 22, 2019

@GrahamcOfBorg build python27Packages.jsonlines python37Packages.jsonlines

@sondr3

This comment has been minimized.

Copy link
Contributor Author

sondr3 commented Nov 11, 2019

ping @jonringer 😅

@jonringer jonringer merged commit 150f62b into NixOS:master Nov 11, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.jsonlines, python37Packages.jsonlines on aarch64-linux Success
Details
python27Packages.jsonlines, python37Packages.jsonlines on x86_64-darwin Success
Details
python27Packages.jsonlines, python37Packages.jsonlines on x86_64-linux Success
Details
@sondr3 sondr3 deleted the sondr3:python-package/jsonlines-init branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.