Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nixos-rebuild: support sudo + --target-host" #71788

Closed
wants to merge 1 commit into from

Conversation

@Mic92
Copy link
Contributor

Mic92 commented Oct 23, 2019

This reverts commit 263a81e.

Only because sudo is used locally does not mean it should be used on
the remote machine:

  • One might use sudo locally because the configuration is not readable by the current user
  • One might not want to type in a sudo password locally while it might be needed when deploying remotely.

Instead it might be better to rely on a proper flag.
cc @bjornfor

Also see #71143 (comment) for a better design.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This reverts commit 263a81e.

Only because sudo is used locally does not mean it should be used on
the remote machine:

- One might use sudo locally because the configuration is not readable by the current user
- One might not want to type in a sudo password locally while it might be needed when deploying remotely.

Instead it might be better to rely on a proper flag.
cc @bjornfor

Also see #71143 (comment) for a better design.
@bjornfor

This comment has been minimized.

Copy link
Contributor

bjornfor commented Oct 24, 2019

#71849 fixes this without reverting (it adds a proper flag).

@bjornfor

This comment has been minimized.

Copy link
Contributor

bjornfor commented Nov 7, 2019

#71849 was merged instead, closing this.

@bjornfor bjornfor closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.