New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-cli: init at 2.0.76 #71797
azure-cli: init at 2.0.76 #71797
Conversation
fyi i'm getting page not found on https://github.com/Azure/azure-cli |
yea, that happened to me suddenly as well. It's back up, and now looks like a fork. I think someone accidentally deleted it.... lol |
I'm able to get the |
also, i need to clean up my git history a bit |
6d01609
to
e5bbcd4
Compare
@FRidh other than making the shell completion work (which isn't mandatory), I think this is ready to go. |
Please get rid of removing those |
It's to help enforce PEP420 on our end for python>=3.5, personally, I think this is the right thing to do. The azure-mgmt-* packages are meant to be composed as a user needs. Their packaging essentially needs you to have wheel==0.30 so that it the interaction between the wheel package, their custom build_azure-wheel.py, and azure-{mgmt-}nspkg package can create the correct wheels for python2 and python3. In the azure-mgmt* packages, I removed the init.py's only if it's python3, and in the azure-cli, I'm under the assumption that it is python3 (but I guess i could make this optional) |
I want to avoid the case where another package has |
1acf282
to
e4d2a4d
Compare
updated the package to 2.0.76 |
@FRidh does this look good to you? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-are-your-goals-for-20-03/4773/2 |
.../development/python-modules/azure-mgmt-appconfiguration/azure-mgmt-apimanagement/default.nix
Outdated
Show resolved
Hide resolved
removed duplicate file and rebased on master |
I was going to wait for 2.0.77 to release, but I'm assuming they won't do a release before black friday, so going to merge. |
Was the node version removed as well? |
It was completely removed from unstable when I added it, and for 19.09, it was just a broken build, so i replaced it. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixos-weekly-01-nixos-weekly/5422/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixops-travis-ci-test-failure-on-azure-private-ip-pr/2441/13 |
Motivation for this change
Add proper azure cli support back into nix after the node "v1.0" was deprecated.
Still have some clean up to do, definitely not in a final state. Just wanted people to comment while still a draft PR.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @