Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cli: init at 2.0.76 #71797

Merged
merged 42 commits into from Nov 24, 2019
Merged

azure-cli: init at 2.0.76 #71797

merged 42 commits into from Nov 24, 2019

Conversation

@jonringer
Copy link
Contributor

jonringer commented Oct 23, 2019

Motivation for this change

Add proper azure cli support back into nix after the node "v1.0" was deprecated.

Still have some clean up to do, definitely not in a final state. Just wanted people to comment while still a draft PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh Oct 23, 2019
@ofborg ofborg bot added the 6.topic: python label Oct 23, 2019
@vyp

This comment has been minimized.

Copy link
Member

vyp commented Oct 23, 2019

fyi i'm getting page not found on https://github.com/Azure/azure-cli

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Oct 23, 2019

fyi i'm getting page not found on https://github.com/Azure/azure-cli

yea, that happened to me suddenly as well. It's back up, and now looks like a fork. I think someone accidentally deleted it.... lol

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Oct 24, 2019

I'm able to get the az command to work... however, i would like a better way to wrap the exectuable. @FRidh how would you wrap https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/az ?

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Oct 24, 2019

also, i need to clean up my git history a bit

@jonringer jonringer mentioned this pull request Oct 25, 2019
5 of 10 tasks complete
@jonringer jonringer force-pushed the jonringer:add-azure-cli branch 2 times, most recently from 6d01609 to e5bbcd4 Oct 29, 2019
@jonringer jonringer marked this pull request as ready for review Oct 29, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Oct 29, 2019

@FRidh other than making the shell completion work (which isn't mandatory), I think this is ready to go.

@jonringer jonringer force-pushed the jonringer:add-azure-cli branch from e5bbcd4 to c1ebc5d Oct 29, 2019
This was referenced Oct 30, 2019
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Oct 31, 2019

Please get rid of removing those __init__ files. Users should always use python.withPackages or python.buildEnv, and users of Python 2 can use python.buildEnv and pass ignoreCollisions to work around the issue with namespace packages.

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Oct 31, 2019

It's to help enforce PEP420 on our end for python>=3.5, personally, I think this is the right thing to do.

The azure-mgmt-* packages are meant to be composed as a user needs. Their packaging essentially needs you to have wheel==0.30 so that it the interaction between the wheel package, their custom build_azure-wheel.py, and azure-{mgmt-}nspkg package can create the correct wheels for python2 and python3.

In the azure-mgmt* packages, I removed the init.py's only if it's python3, and in the azure-cli, I'm under the assumption that it is python3 (but I guess i could make this optional)

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Oct 31, 2019

I want to avoid the case where another package has azure-applicationinsights and azure-mgmt-storage, but can only see one of them.

@jonringer jonringer changed the title azure-cli: init at 2.0.75 azure-cli: init at 2.0.76 Nov 7, 2019
@jonringer jonringer force-pushed the jonringer:add-azure-cli branch 2 times, most recently from 1acf282 to e4d2a4d Nov 7, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 7, 2019

updated the package to 2.0.76

@jonringer jonringer force-pushed the jonringer:add-azure-cli branch from e4d2a4d to 013da19 Nov 7, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 7, 2019

@FRidh does this look good to you?

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Nov 14, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-are-your-goals-for-20-03/4773/2

@jonringer jonringer force-pushed the jonringer:add-azure-cli branch from 013da19 to acbf802 Nov 17, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 17, 2019

removed duplicate file and rebased on master

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 24, 2019

I was going to wait for 2.0.77 to release, but I'm assuming they won't do a release before black friday, so going to merge.

@jonringer jonringer merged commit 85fc419 into NixOS:master Nov 24, 2019
16 checks passed
16 checks passed
azure-cli on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
azure-cli on aarch64-linux Success
Details
azure-cli on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:add-azure-cli branch Nov 24, 2019
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 6, 2019

Was the node version removed as well?

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Dec 6, 2019

It was completely removed from unstable when I added it, and for 19.09, it was just a broken build, so i replaced it.

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Jan 10, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-weekly-01-nixos-weekly/5422/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.