Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.09] libpcap, tcpdump: 1.9.1 and 4.9.3 for many security fixes #72028

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 26, 2019

Motivation for this change

Backport of #70249

There seem to be too many issues to address this through patches.

Too many reverse dependencies for me to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

dtzWill added 2 commits Oct 2, 2019
http://www.tcpdump.org/libpcap-changes.txt

> Five CVE-2019-15161, CVE-2019-15162, CVE-2019-15163, CVE-2019-15164, CVE-2019-15165
> Fixes for CVE-2018-16301,

Drop the included patch as well.

(cherry picked from commit 4db088d)
So many CVE's, see:

http://www.tcpdump.org/tcpdump-changes.txt
(cherry picked from commit dd42253)
@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 27, 2019

@GrahamcOfBorg build tcpdump

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Oct 28, 2019

waiting for ofBorg...

@grahamc I've trouble interpreting the graphs at https://monitoring.nix.ci/ -- is ofBorg working normally or is it stuck?

@FRidh FRidh added this to Needs review in Staging (stable) Nov 3, 2019
@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Nov 15, 2019

Compiled & smoke-tested both on NixOS and Darwin.

@ckauhaus ckauhaus merged commit e1cc8ff into NixOS:staging-19.09 Nov 15, 2019
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libpcap, tcpdump on aarch64-linux Success
Details
libpcap, tcpdump on x86_64-linux Success
Details
tcpdump on aarch64-linux Success
Details
tcpdump on x86_64-linux Success
Details
Staging (stable) automation moved this from Needs review to Done Nov 15, 2019
@c0bw3b c0bw3b mentioned this pull request Dec 4, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.