Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keeperrl: init at 2019-10-21 #72051

Closed
wants to merge 2 commits into from
Closed

keeperrl: init at 2019-10-21 #72051

wants to merge 2 commits into from

Conversation

@rardiol
Copy link
Contributor

@rardiol rardiol commented Oct 26, 2019

Motivation for this change

Late follow up of #43409, updated to the latest stable branch(I think it's alpha29 hotfix1, but there's no tag so I'm not sure.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@rardiol rardiol force-pushed the rardiol:keeperrl branch from b1a7b0d to aec7202 Oct 26, 2019
libGL, makeWrapper, boost, makeDesktopItem }:

stdenv.mkDerivation rec {
pname = "keeperrl";

This comment has been minimized.

@mmahut

mmahut Oct 27, 2019
Member

Suggested change
pname = "keeperrl";
pname = "keeperrl-unstable";

This comment has been minimized.

@mmahut

mmahut Oct 27, 2019
Member

Or 29.1?

This comment has been minimized.

@Infinisil

Infinisil Oct 27, 2019
Member

Wouldn't it make more sense to include unstable in the version as version = "unstable-2019-10-21"?

pkgs/games/keeperrl/default.nix Outdated Show resolved Hide resolved
@mmahut
Copy link
Member

@mmahut mmahut commented Oct 27, 2019

@GrahamcOfBorg build keeperrl

Co-Authored-By: Marek Mahut <marek.mahut@gmail.com>
src = fetchFromGitHub {
owner = "miki151";
repo = "keeperrl";
rev = "74b89ea";

This comment has been minimized.

@Infinisil

Infinisil Oct 27, 2019
Member

Use the full revision, not a shorthand form, because shorthand forms can become ambiguous

] ++ stdenv.lib.optional stdenv.isDarwin boost ;

# Needed so the builder finds SDL.h
CFLAGS = "-I${SDL2.dev}/include/SDL2";

This comment has been minimized.

@Infinisil

Infinisil Oct 27, 2019
Member

I think NIX_CFLAGS_COMPILE = [ "-I ..." ] should be used instead, which will end up in CFLAGS but with some extra stuff.

@stale
Copy link

@stale stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 1, 2020
@rardiol rardiol closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.