Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaff: init at 0.1.1 #72108

Merged
merged 1 commit into from Feb 10, 2020
Merged

scaff: init at 0.1.1 #72108

merged 1 commit into from Feb 10, 2020

Conversation

@jD91mZM2
Copy link
Member

@jD91mZM2 jD91mZM2 commented Oct 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Nov 15, 2019

@GrahamcOfBorg build scaff

@jD91mZM2
Copy link
Member Author

@jD91mZM2 jD91mZM2 commented Jan 7, 2020

Is a bump allowed?

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Jan 7, 2020

Of course - go ahead

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Jan 7, 2020

What bugs me a bit is potential pkgs tree bloat. The diff is quite huge for such a simple tool.

@jD91mZM2
Copy link
Member Author

@jD91mZM2 jD91mZM2 commented Jan 7, 2020

Understandable! Feel free to close this if you don't see it fitting in nixpkgs :)

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Jan 7, 2020

Even better would be to get it in with less nix code. Is there a possibility to use alternative Rust build support?

@jD91mZM2
Copy link
Member Author

@jD91mZM2 jD91mZM2 commented Jan 8, 2020

Sure! It just takes longer to build, but it's definitely possible. Will do ASAP :)

@jD91mZM2 jD91mZM2 force-pushed the jD91mZM2:scaff branch from 209b02a to 8d6e476 Jan 9, 2020
@jD91mZM2
Copy link
Member Author

@jD91mZM2 jD91mZM2 commented Jan 9, 2020

Finally, done. Apologies for the delay :)

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Jan 13, 2020

@jD91mZM2 The pkg definition is missing a metadata section.

@jD91mZM2
Copy link
Member Author

@jD91mZM2 jD91mZM2 commented Jan 14, 2020

Oh, oops, sorry

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Feb 5, 2020

@jD91mZM2 ping - any news here? Just add a metadata section and it's done.

@jD91mZM2
Copy link
Member Author

@jD91mZM2 jD91mZM2 commented Feb 5, 2020

Oh, I forgot this, thanks for the ping!

@jD91mZM2 jD91mZM2 force-pushed the jD91mZM2:scaff branch from 8d6e476 to 6293f00 Feb 5, 2020
@ckauhaus ckauhaus merged commit b2abf36 into NixOS:master Feb 10, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
scaff on aarch64-linux Success
Details
scaff on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.