Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avldrums: 0.3.5 -> 0.4.0 #72127

Merged
merged 1 commit into from Nov 16, 2019
Merged

avldrums: 0.3.5 -> 0.4.0 #72127

merged 1 commit into from Nov 16, 2019

Conversation

@magnetophon
Copy link
Member

magnetophon commented Oct 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

jonringer left a comment

is this right? this doesn't seem like the correct install paths:

[nix-shell:/home/jon/.cache/nix-review/pr-72127]$ tree ./results/avldrums-lv2
./results/avldrums-lv2
└── lib
    └── lv2
        └── avldrums.lv2
            ├── avldrums.so
            ├── avldrums.ttl
            ├── avldrumsUI_gl.so
            ├── Black_Pearl_4_LV2.sf2
            ├── manifest.ttl
            └── Red_Zeppelin_4_LV2.sf2
@magnetophon

This comment has been minimized.

Copy link
Member Author

magnetophon commented Oct 28, 2019

LGTM; for comparison, here's the tree of another set of lv2 plugins:

├── lib
│   └── lv2
│       ├── balance.lv2
│       │   ├── balance.so
│       │   ├── balance.ttl
│       │   ├── balanceUI.so
│       │   └── manifest.ttl
│       ├── controlfilter.lv2
│       │   ├── controlfilter.so
│       │   ├── controlfilter.ttl
│       │   ├── manifest.ttl
│       │   └── presets.ttl
│       ├── convo.lv2
│       │   ├── convoLV2.so
│       │   ├── convoLV2.ttl
│       │   └── manifest.ttl
│       ├── darc.lv2
│       │   ├── darc.so
│       │   ├── darc.ttl
│       │   ├── darcUI_gl.so
│       │   └── manifest.ttl
│       ├── dpl.lv2
│       │   ├── dpl.so
│       │   ├── dpl.ttl
│       │   ├── dplUI_gl.so
│       │   └── manifest.ttl
│       ├── fat1.lv2
│       │   ├── fat1.so
│       │   ├── fat1.ttl
│       │   ├── fat1UI_gl.so
│       │   └── manifest.ttl
│       ├── fil4.lv2
│       │   ├── fil4.so
│       │   ├── fil4.ttl
│       │   ├── fil4UI_gl.so
│       │   └── manifest.ttl
│       ├── matrixmixer.lv2
│       │   ├── manifest.ttl
│       │   ├── matrixmixer.so
│       │   ├── matrixmixer.ttl
│       │   └── matrixmixerUI_gl.so
│       ├── meters.lv2
│       │   ├── manifest.ttl
│       │   ├── meters_glui.so
│       │   ├── meters.so
│       │   └── meters.ttl
│       ├── mididebug.lv2
│       │   ├── manifest.ttl
│       │   ├── mididebug.so
│       │   └── mididebug.ttl
│       ├── midifilter.lv2
│       │   ├── manifest.ttl
│       │   ├── midifilter.so
│       │   ├── midifilter.ttl
│       │   └── presets.ttl
│       ├── midigen.lv2
│       │   ├── manifest.ttl
│       │   ├── midigen.so
│       │   └── midigen.ttl
│       ├── midimap.lv2
│       │   ├── manifest.ttl
│       │   ├── midimap.so
│       │   ├── midimap.ttl
│       │   └── presets.ttl
│       ├── mixtri.lv2
│       │   ├── manifest.ttl
│       │   ├── mixtri.so
│       │   ├── mixtri.ttl
│       │   └── mixtriUI_gl.so
│       ├── nodelay.lv2
│       │   ├── manifest.ttl
│       │   ├── nodelay.so
│       │   └── nodelay.ttl
│       ├── onsettrigger.lv2
│       │   ├── manifest.ttl
│       │   ├── onsettrigger.so
│       │   └── onsettrigger.ttl
│       ├── sisco.lv2
│       │   ├── manifest.ttl
│       │   ├── sisco.so
│       │   ├── sisco.ttl
│       │   └── siscoUI_gl.so
│       ├── spectra.lv2
│       │   ├── manifest.ttl
│       │   ├── spectra.so
│       │   ├── spectra.ttl
│       │   └── spectraUI_gl.so
│       ├── stepseq_s8n8.lv2
│       │   ├── manifest.ttl
│       │   ├── stepseq.so
│       │   ├── stepseq.ttl
│       │   └── stepseqUI_gl.so
│       ├── stereoroute.lv2
│       │   ├── manifest.ttl
│       │   ├── stereoroute.so
│       │   └── stereoroute.ttl
│       ├── testsignal.lv2
│       │   ├── manifest.ttl
│       │   ├── testsignal.so
│       │   └── testsignal.ttl
│       ├── tuna.lv2
│       │   ├── manifest.ttl
│       │   ├── tuna.so
│       │   ├── tuna.ttl
│       │   └── tunaUI_gl.so
│       └── xfade.lv2
│           ├── manifest.ttl
│           ├── xfade.so
│           └── xfade.ttl
└── share
    └── man
        └── man1
            ├── x42-darc.1.gz
            ├── x42-dpl.1.gz
            ├── x42-fat1.1.gz
            ├── x42-fil4.1.gz
            ├── x42-matrixmixer.1.gz
            ├── x42-meter.1.gz
            ├── x42-mixtri.1.gz
            ├── x42-scope.1.gz
            ├── x42-spectr.1.gz
            ├── x42-stepseq.1.gz
            └── x42-tuna.1.gz

What's more, avldrums.l2 is found by the programs that need to find it.
Am I overlooking something?

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Oct 28, 2019

Generally i see the .so's directly under lib, and there's not a package that I can verify is able to link against it.

I don't think this is a regression, and could be intended behavior, just saying it's odd

@magnetophon

This comment has been minimized.

Copy link
Member Author

magnetophon commented Oct 28, 2019

I've taken various samples and all lv2's I tested where structured like this.
I think we're good! ;)

@magnetophon

This comment has been minimized.

Copy link
Member Author

magnetophon commented Nov 15, 2019

@marsam I'm gonna take you up on your offer: ping! ;)

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 16, 2019

oh sorry, I passed this over

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM

[3 built, 4 copied (42.9 MiB), 5.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72127
1 package were build:
avldrums-lv2
@jonringer jonringer merged commit 82ed6bd into NixOS:master Nov 16, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@magnetophon

This comment has been minimized.

Copy link
Member Author

magnetophon commented Nov 16, 2019

@jonringer Thanks!

@magnetophon magnetophon deleted the magnetophon:avldrums branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.