Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.CryptECB: init at 2.21 #72214

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@tekeri
Copy link
Contributor

@tekeri tekeri commented Oct 29, 2019

Motivation for this change

Add a missing perl package.

This is my first contribution to the open source project. Feel free to teach me anything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@tekeri
Copy link
Contributor Author

@tekeri tekeri commented Oct 29, 2019

EDIT: Changed maintainer @??? to @FRidh

@tekeri
Copy link
Contributor Author

@tekeri tekeri commented Nov 11, 2019

cc @c0bw3b
Could you?

@tekeri tekeri changed the title perl5.28.2-Crypt-ECB: init at 2.21 perlPackages-Crypt-ECB: init at 2.21 Nov 11, 2019
@tekeri tekeri changed the title perlPackages-Crypt-ECB: init at 2.21 perlPackages.Crypt-ECB: init at 2.21 Nov 11, 2019
@tekeri tekeri changed the title perlPackages.Crypt-ECB: init at 2.21 perlPackages.CryptECB: init at 2.21 Nov 11, 2019
@tekeri tekeri force-pushed the tekeri:feature/add-perl-module-crypt-ecb branch from 297ce92 to 90679df Nov 11, 2019
@tekeri
Copy link
Contributor Author

@tekeri tekeri commented Nov 11, 2019

Fixed name

@tekeri tekeri force-pushed the tekeri:feature/add-perl-module-crypt-ecb branch from 90679df to cc780aa Nov 12, 2019
Copy link
Member

@stigtsp stigtsp left a comment

Looks good to me

Result of nix-review pr 72214 1

2 package were build:
  • perl528Packages.CryptECB
  • perl530Packages.CryptECB
@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 15, 2019

@GrahamcOfBorg build perl528Packages.CryptECB perl530Packages.CryptECB

@c0bw3b
c0bw3b approved these changes Nov 15, 2019
@c0bw3b c0bw3b merged commit d6fa540 into NixOS:master Nov 15, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perl528Packages.CryptECB, perl530Packages.CryptECB on aarch64-linux Success
Details
perl528Packages.CryptECB, perl530Packages.CryptECB on x86_64-darwin Success
Details
perl528Packages.CryptECB, perl530Packages.CryptECB on x86_64-linux Success
Details
@tekeri tekeri deleted the tekeri:feature/add-perl-module-crypt-ecb branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.