Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepalived: 1.4.2 -> 1.4.5, patch CVE-2018-19115 #72278

Merged
merged 2 commits into from Nov 9, 2019

Conversation

@risicle
Copy link
Contributor

risicle commented Oct 29, 2019

Motivation for this change

Patches https://nvd.nist.gov/vuln/detail/CVE-2018-19115

Also bumped to last release of 1.4.x series. Why not the newer 2.x series? I have never used keepalived and this package has no maintainer listed, so I'm being conservative, not wanting to break anything...

Will probably backport the patch without the bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
c0bw3b approved these changes Oct 31, 2019
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Oct 31, 2019

I think we should backport patch and version bump here. This is an old enough codebase, surely there is some bugfixes worth shipping in the release.

Note that upstream calls for distros updating to 2.x on its homepage :

[October 21, 2018] This short note to encourage every package mainteners to update keepalived distro package. Most of current version shipped with major distro are stuck to 1.3.X release. Keepalived code present in git master branch must be considered as stable and futur proof. We do not backport bugfixes and extensions to previous release, dev circle is an allways forward release process. So you are strongly encouraged to upgrade to last 2.X release which provides extensive work, extensions and bugfixes

In our case it would also mean revamping the associated service module. Although it's not a highly complex service, it's probably best done by someone actually using it.

@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Oct 31, 2019

Re: new maintainer - Absolutely - I was asking around on IRC and andi- identified himself as a user of it at least.

@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Oct 31, 2019

A start would be to have a nixos test for it so we can easily see if we're breaking the module.

@vcunat
vcunat approved these changes Nov 9, 2019
vcunat added a commit that referenced this pull request Nov 9, 2019
@vcunat vcunat merged commit 03d6145 into NixOS:master Nov 9, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
keepalived on aarch64-linux Success
Details
keepalived on x86_64-linux Success
Details
vcunat added a commit that referenced this pull request Nov 9, 2019
(cherry picked from commit 03d6145)
@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Nov 9, 2019

/cc @mbrgm, as I see several keepalived bumps from them.

I know almost nothing about it; for now I just picked the patch to stables. If "you" feel like it, add more.

vcunat added a commit that referenced this pull request Nov 9, 2019
(cherry picked from commit 03d6145)
@mbrgm

This comment has been minimized.

Copy link
Member

mbrgm commented Nov 12, 2019

It's quite some time since I used keepalived on NixOS... and back then, it was only in a test environment, no production usage. PR looks good to me... however, I currently don't have anything in place to properly test the behavior besides running the binary. As @risicle suggested, a NixOS test could prove quite valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.