Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pidgin-opensteamworks: git-2018-08-02 -> 1.7 #72295

Open
wants to merge 1 commit into
base: master
from

Conversation

@Shados
Copy link
Contributor

Shados commented Oct 30, 2019

Motivation for this change

pidgin-opensteamworks finally did a new versioned release last month (since 1.6.1 in 2015), so it seemed like a good time to update the expression again :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
};

preConfigure = "cd steam-mobile";
preConfigure = ''
cd steam-mobile

This comment has been minimized.

Copy link
@c0bw3b

c0bw3b Oct 31, 2019

Contributor

You can replace the preConfigure hook with sourceRoot = "source/steam-mobile";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.