Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-custodian: init at 0.8.45.1 #72325

Merged
merged 1 commit into from Nov 9, 2019
Merged

Conversation

@bhipple
Copy link
Contributor

bhipple commented Oct 30, 2019

Motivation for this change

Tool for managing cloud cluster security/cost/etc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

jonringer left a comment

if you're going to remain an application outside of python-modules, then you should pass in the python interpreter to the expression and use python.pkgs to access the packages

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@bhipple bhipple force-pushed the bhipple:add/cloud-custodian branch from 5e7f9aa to 459f430 Oct 31, 2019
@bhipple

This comment has been minimized.

Copy link
Contributor Author

bhipple commented Oct 31, 2019

Thanks @jonringer; updated accordingly. Looks nicer, and the package even has the same hash after refactoring to validate!

@GrahamcOfBorg build cloud-custodian

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Oct 31, 2019

@FRidh just want to make sure this is a best practice, as it looks good to me :)

@bhipple

This comment has been minimized.

Copy link
Contributor Author

bhipple commented Nov 8, 2019

@jonringer @FRidh any updates on this one? Happy to make further changes if necessary.

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@bhipple bhipple force-pushed the bhipple:add/cloud-custodian branch from 43887a9 to 5917f58 Nov 9, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 9, 2019

@GrahamcOfBorg build cloud-custodian

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
executable shows usage

[3 built, 14 copied (39.9 MiB), 3.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72325
1 package were build:
cloud-custodian
@jonringer jonringer merged commit f302f02 into NixOS:master Nov 9, 2019
15 of 16 checks passed
15 of 16 checks passed
cloud-custodian on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
cloud-custodian on aarch64-linux Success
Details
cloud-custodian on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.