Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fontconfig-ultimate: remove #72369

Merged
merged 3 commits into from Nov 7, 2019
Merged

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Oct 31, 2019

Motivation for this change

See discussion at #67529. This was long overdue.

I also removed fonts.enableCoreFonts as it also looked due for removal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace requested a review from Infinisil as a code owner Oct 31, 2019
@worldofpeace worldofpeace requested review from jtojnar and volth Oct 31, 2019
@volth
volth approved these changes Oct 31, 2019
Copy link
Contributor

volth left a comment

@jtojnar jtojnar added this to To do in Picking up garbage via automation Oct 31, 2019
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Oct 31, 2019
@vcunat
vcunat approved these changes Nov 2, 2019
Copy link
Member

vcunat left a comment

Sounds good. (I didn't really check for typos, etc.)

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 6, 2019

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Nov 6, 2019

This PR's eval came in at a wonderful time where github had a bug and has since periodically exposed other bugs in github. If you wouldn't mind, would you rebase this PR again, which would work around the bug in ofborg for now?

4 years ago in 7edb27b the option was made
hidden. We should just remove the module and use mkRemovedOptionModule.
@worldofpeace worldofpeace force-pushed the worldofpeace:corefonts-drop branch from 9b78ebb to 5e9caed Nov 6, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 6, 2019

This PR's eval came in at a wonderful time where github had a bug and has since periodically exposed other bugs in github. If you wouldn't mind, would you rebase this PR again, which would work around the bug in ofborg for now?

Done, I was considering if that was going to be my only option anyways 😄

This module has been obsolete for several years now.
@jtojnar
jtojnar approved these changes Nov 6, 2019
@worldofpeace worldofpeace merged commit 7c71670 into NixOS:master Nov 7, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Picking up garbage automation moved this from In progress to Done Nov 7, 2019
@worldofpeace worldofpeace deleted the worldofpeace:corefonts-drop branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.