Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
rustc: add support for armv7l targets #72480
Motivation for this change
rustc and Rust packages would not compile on Raspbian on a Raspberry Pi. It turns out that Rust's ARMv7 targets are slightly different from Nix's.
Addresses issue #72473
This change adds a function that maps
In addition, this change also disables the
Addresses issue #72473 `rustc` and Rust packages would not compile on Raspbian on a Raspberry Pi. It turns out that Rust's ARMv7 targets are slightly different from Nix's. This change adds a function that maps `armv7a` and `armv7l` architectures to `armv7`. The former are used in Raspbian on Raspberry Pi but are unknown to rustc. Rust knows only `armv7`.
Sorry for not responding, but I can submit my own version of the PR if you want. I see that you integrated most of it already, but I noticed a couple of things still missing (in
Also, we put our mapping functions inside different attrsets (
Yes, I intentionally left some things out because they caused errors in CI. I recommend we attack this problem in 2 steps. This PR goes in first (since it has already been reviewed and approved) and then the second PR (where you'll put in the improvements) can be much smaller and easier to review. Does that sound reasonable?…
On Fri, 15 Nov 2019, 21:02 Ben Wolsieffer, ***@***.***> wrote: I submitted it: #73472 <#73472> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#72480?email_source=notifications&email_token=AAF4I6M7MPJGWTOT42NIWDTQT4E43A5CNFSM4JH7VYFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGWRTI#issuecomment-554526925>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAF4I6JFWUSG2VWH5XHSSQDQT4E43ANCNFSM4JH7VYFA> .
Here is my updated mapping function: https://github.com/NixOS/nixpkgs/pull/73472/files#diff-4100057d032c0d790107c2739448233cR14
It is not the most elegant, but it works for all the platforms that we have bootstrap tarballs for, as well as MinGW (which actually did not need a special case) and armv7a.