Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.09] perlPackages.libapreq2: add patch for CVE-2019-12412 #72483

Merged

Conversation

@risicle
Copy link
Contributor

risicle commented Nov 1, 2019

Motivation for this change

https://security-tracker.debian.org/tracker/CVE-2019-12412

Backport of #70479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

(cherry picked from commit 68d4a1b)
@risicle risicle changed the title perlPackages.libapreq2: add patch for CVE-2019-12412 [r19.09] perlPackages.libapreq2: add patch for CVE-2019-12412 Nov 1, 2019
@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Nov 9, 2019

@GrahamcOfBorg build perl528Packages.libapreq2

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 9, 2019

(checking Darwin too)
@GrahamcOfBorg build perl528Packages.libapreq2 perl530Packages.libapreq2

@c0bw3b
c0bw3b approved these changes Nov 9, 2019
Copy link
Contributor

c0bw3b left a comment

Result of nix-review pr 72483 1

2 package were build:
  • perl528Packages.libapreq2
  • perl530Packages.libapreq2
@c0bw3b c0bw3b merged commit 0bf9901 into NixOS:release-19.09 Nov 9, 2019
18 checks passed
18 checks passed
perl528Packages.libapreq2, perl530Packages.libapreq2 on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perl528Packages.libapreq2 on aarch64-linux Success
Details
perl528Packages.libapreq2 on x86_64-linux Success
Details
perl528Packages.libapreq2, perl530Packages.libapreq2 on aarch64-linux Success
Details
perl528Packages.libapreq2, perl530Packages.libapreq2 on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.