Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topgrade: init at 3.2.0 #72555

Closed
wants to merge 2 commits into from
Closed

topgrade: init at 3.2.0 #72555

wants to merge 2 commits into from

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 2, 2019

Summary of changes

  • maintainers: add filalex77

  • topgrade: init at 3.2.0

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.


This change is Reviewable

filalex77 added 2 commits Nov 2, 2019
@filalex77 filalex77 force-pushed the filalex77:topgrade-3.2.0 branch from 2ebcb8d to d1a7263 Nov 2, 2019
@filalex77 filalex77 marked this pull request as ready for review Nov 2, 2019
@filalex77 filalex77 closed this Nov 7, 2019
@filalex77 filalex77 deleted the filalex77:topgrade-3.2.0 branch Nov 7, 2019
@filalex77

This comment has been minimized.

Copy link
Contributor Author

filalex77 commented Nov 7, 2019

Closing in favor of updating to 3.3.0 and waiting for me to be included as a maintainer in #72971.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.