Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stone-phaser: init at 0.1.2 #72710

Merged
merged 1 commit into from Nov 16, 2019
Merged

stone-phaser: init at 0.1.2 #72710

merged 1 commit into from Nov 16, 2019

Conversation

@magnetophon
Copy link
Member

magnetophon commented Nov 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

];

patchPhase = ''
patch -d dpf -p 1 -i "`pwd`/resources/patch/DPF-bypass.patch"

This comment has been minimized.

Copy link
@vyp

vyp Nov 3, 2019

Member
Suggested change
patch -d dpf -p 1 -i "`pwd`/resources/patch/DPF-bypass.patch"
patch -d dpf -p 1 -i "resources/patch/DPF-bypass.patch"

Is pwd needed here? The unpack phase should have copied the src to the current directory I think.

This comment has been minimized.

Copy link
@magnetophon

magnetophon Nov 3, 2019

Author Member

Seems like it is, without I get: patch: **** Can't open patch file resources/patch/DPF-bypass.patch : No such file or directory.

This comment has been minimized.

Copy link
@vyp

vyp Nov 4, 2019

Member

Oh interesting, my bad 👍

@magnetophon

This comment has been minimized.

Copy link
Member Author

magnetophon commented Nov 15, 2019

@marsam Wanna take a look here as well?

Copy link
Contributor

marsam left a comment

I left a pair of comments. Besides that, LGTM

pkgs/applications/audio/stone-phaser/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/stone-phaser/default.nix Outdated Show resolved Hide resolved
@magnetophon magnetophon force-pushed the magnetophon:stone-phaser branch from ad3b3b7 to 19562e3 Nov 16, 2019
@marsam
marsam approved these changes Nov 16, 2019
@marsam marsam merged commit 4800a71 into NixOS:master Nov 16, 2019
15 checks passed
15 checks passed
stone-phaser on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
stone-phaser on x86_64-linux Success
Details
@magnetophon magnetophon deleted the magnetophon:stone-phaser branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.