Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tre-command: init at 0.2.2 #72738

Merged
merged 2 commits into from Nov 4, 2019
Merged

tre-command: init at 0.2.2 #72738

merged 2 commits into from Nov 4, 2019

Conversation

@dduan
Copy link
Contributor

dduan commented Nov 3, 2019

Motivation for this change

tre is a improved version of the command tree. It's main additions:

  1. colored output
  2. ignores paths specified in .gitignore
  3. editor alias for each entity listed

Source/Homepage: https://github.com/dduan/tre

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

I'd like to be maintainer of this package for Nix. (I'm the author of the CLI tool).

@dduan dduan force-pushed the dduan:tre branch from ef19dfd to 329afc5 Nov 3, 2019
@dduan dduan closed this Nov 3, 2019
@dduan dduan reopened this Nov 3, 2019
@dduan dduan force-pushed the dduan:tre branch from 329afc5 to 9ea86db Nov 3, 2019
@dduan dduan closed this Nov 3, 2019
@dduan dduan reopened this Nov 3, 2019
@dduan dduan force-pushed the dduan:tre branch from 9ea86db to 11a143b Nov 3, 2019
@dduan

This comment has been minimized.

Copy link
Contributor Author

dduan commented Nov 3, 2019

@mmahut thanks for your review! I've addressed your feedbacks.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
tre is a improved version of the command `tree`. Its main additions:

1. colored output
2. ignores paths specified in .gitignore
3. editor alias for each entity listed

Source/Homepage: https://github.com/dduan/tre
@dduan dduan force-pushed the dduan:tre branch from 437efb6 to fcd88c8 Nov 3, 2019
@dduan dduan changed the title tre: init at 0.2.2 tre-command: init at 0.2.2 Nov 3, 2019
@dduan dduan requested a review from mmahut Nov 3, 2019
@dduan

This comment has been minimized.

Copy link
Contributor Author

dduan commented Nov 4, 2019

@mmahut lemme know if there's further improvement to be made in order for this to be merged. Thanks for your help so far!

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Nov 4, 2019

@GrahamcOfBorg build tre-command

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Nov 4, 2019

Looks good to me. Thank you Daniel for your contribution and welcome! :)

@mmahut mmahut merged commit ba76515 into NixOS:master Nov 4, 2019
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tre on aarch64-linux Success
Details
tre on x86_64-linux Success
Details
tre-command on aarch64-linux Success
Details
tre-command on x86_64-darwin Success
Details
tre-command on x86_64-linux Success
Details
@dduan dduan deleted the dduan:tre branch Nov 4, 2019
@jonringer jonringer mentioned this pull request Nov 6, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.