Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twa: 1.8.0 -> 1.9.1 #72742

Merged
merged 1 commit into from Nov 11, 2019
Merged

twa: 1.8.0 -> 1.9.1 #72742

merged 1 commit into from Nov 11, 2019

Conversation

@Avaq
Copy link
Contributor

Avaq commented Nov 3, 2019

Motivation for this change

To close #72689 by providing a working alternative

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Avaq

This comment has been minimized.

Copy link
Contributor Author

Avaq commented Nov 3, 2019

I have found two minor issues in this version of twa: trailofbits/twa#66 and trailofbits/twa#67. I'm expecting the author to fix these soon. If this PR has not been merged by that time, I will update the package version and PR title.

@woodruffw

This comment has been minimized.

Copy link

woodruffw commented Nov 3, 2019

Upstream here: Thanks. I've cut 1.9.1 with both fixes.

@Avaq Avaq force-pushed the Avaq:avaq/twa-190 branch from e55ef14 to 8b166de Nov 3, 2019
@Avaq Avaq changed the title twa: 1.8.0 -> 1.9.0 twa: 1.8.0 -> 1.9.1 Nov 3, 2019
@Avaq

This comment has been minimized.

Copy link
Contributor Author

Avaq commented Nov 3, 2019

Updated to 1.9.1 and retested. Upstream fixes confirmed.

gawk
host.dnsutils
jq
makeWrapper

This comment has been minimized.

Copy link
@c0bw3b

c0bw3b Nov 9, 2019

Contributor

makeWrapper belongs in nativeBuildInputs as it's used during build but not necessary at runtime.

This commit updates twa from version 1.8.0 to version 1.9.1,
specifying its new 'jq' dependency.

It also moves 'makeWrapper' from the build inputs to the native
build inputs, as it's not necessary during runtime.
@Avaq Avaq force-pushed the Avaq:avaq/twa-190 branch from 8b166de to 776d4c1 Nov 11, 2019
@Avaq

This comment has been minimized.

Copy link
Contributor Author

Avaq commented Nov 11, 2019

@c0bw3b I moved makeWrapper to the nativeBuildInputs, also describing the change in the commit message.

@c0bw3b
c0bw3b approved these changes Nov 11, 2019
Copy link
Contributor

c0bw3b left a comment

Builds and runs

@c0bw3b c0bw3b merged commit c64e9da into NixOS:master Nov 11, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
twa on aarch64-linux Success
Details
twa on x86_64-linux Success
Details
@Avaq Avaq deleted the Avaq:avaq/twa-190 branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.