Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc,python.pkgs.libfdt: drop python buildInput #72744

Merged
merged 1 commit into from Oct 25, 2020
Merged

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Nov 3, 2019

Motivation for this change

This doesn't seem to be necessary to build the library with
strictDeps = true, or when cross-compiling.

Would appreciate somebody who uses this with Python doing a sanity check for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This doesn't seem to be necessary to build the library with
strictDeps = true, or when cross-compiling.
@stale
Copy link

@stale stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale label Jun 1, 2020
@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 25, 2020

Result of nixpkgs-review pr 72744 1

1 package marked as broken and skipped:
- odroid-xu3-bootloader
7 packages built:
- diffoscope
- dtc
- fwts
- python27Packages.libfdt
- python37Packages.libfdt
- python38Packages.libfdt
- ubootTools

@bhipple bhipple merged commit f20b89d into NixOS:master Oct 25, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants