Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
nixos/phpfpm: fix apply global phpOptions #72767
Motivation for this change
Fixed apply of parameter
The name of the option immediately shows that it applies to all pools.
And here it is easy to deteсt which parameters belong to global:
etu left a comment
The same as @aanderse.
I don't see the point in this rename and I think we shouldn't do it.
Maybe it's possible to do if we do a big refactor or something at the same time so we actually gain some more benefits from the module. But as far as I can see from reading the diff here... we don't really change anything that much really...
aanderse left a comment
@Izorkin please try this instead:
This would allow you to customize much further, more flexibility.
generates a file in this form
How to make lines displayed first: