Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openarena: Update link from oa_ded to openarena-server #72824

Closed
wants to merge 1 commit into from

Conversation

@kevincox
Copy link
Contributor

@kevincox kevincox commented Nov 5, 2019

230fc22 was lost in #71122

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

230fc22 was lost in #71122
@kevincox
Copy link
Contributor Author

@kevincox kevincox commented Nov 5, 2019

@tomfitzhenry

This preserves the previous behavior. Alternatively we can keep the binary name used in the distribution and update the nixos config and test.

@tomfitzhenry
Copy link
Contributor

@tomfitzhenry tomfitzhenry commented Nov 5, 2019

@kevincox
Copy link
Contributor Author

@kevincox kevincox commented Nov 5, 2019

Yeah, that is what I would do just to keep the binary name consistent. Do you want to send a patch for that then?

tomfitzhenry added a commit to tomfitzhenry/nixpkgs that referenced this pull request Nov 17, 2019
The binary name was recently changed from openarena-server to oa_ded in
NixOS#71122 .

That change broke the openarena module and consequently the openarena
test too. This commit fixes both.

As an alternative, we considered reverting the name change in
NixOS#72824 but we decided oa_ded was
a better name for the binary (it's the name upstream use).
@tomfitzhenry tomfitzhenry mentioned this pull request Nov 17, 2019
3 of 10 tasks complete
tomfitzhenry added a commit to tomfitzhenry/nixpkgs that referenced this pull request Nov 17, 2019
The binary name was recently changed from openarena-server to oa_ded in
NixOS#71122 .

That change broke the openarena module and consequently the openarena
test too. This commit fixes both.

As an alternative, we considered reverting the name change in
NixOS#72824 but we decided oa_ded was
a better name for the binary (it's the name upstream use).
Lassulus added a commit that referenced this pull request Nov 24, 2019
The binary name was recently changed from openarena-server to oa_ded in
#71122 .

That change broke the openarena module and consequently the openarena
test too. This commit fixes both.

As an alternative, we considered reverting the name change in
#72824 but we decided oa_ded was
a better name for the binary (it's the name upstream use).
@veprbl
Copy link
Member

@veprbl veprbl commented Feb 9, 2020

My understanding, this is not needed after #73553

@veprbl veprbl closed this Feb 9, 2020
@veprbl veprbl deleted the kevincox-openarena-server-1 branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.