Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.jsonrpclib-pelix: Remove moredread as maintainer #72852

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@Moredread
Copy link
Contributor

Moredread commented Nov 5, 2019

Motivation for this change

See #54249

In short, I don't feel comfortable to maintain such a security critical dependency for a cryptocurrency package (electrum etc.) at the moment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Moredread Moredread requested review from FRidh and jonringer as code owners Nov 5, 2019
@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Nov 5, 2019

@ofborg ofborg bot added the 6.topic: python label Nov 5, 2019
@Moredread Moredread force-pushed the Moredread:maintainer-removal branch from dc87e95 to 6a8ddd5 Nov 5, 2019
@Moredread Moredread force-pushed the Moredread:maintainer-removal branch from 6a8ddd5 to c69c7fc Nov 5, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 5, 2019

security concerns are largely an upstream issue, all we can do is mark that there are known vulnerabilities, apply patches, or bump the version.

If you don't feel comfortable maintaining it, then I can remove you

@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Nov 6, 2019

Mhh, it looks it isn't a dependency anymore. spesmilo/electrum#4825 spesmilo/electrum@5df5aaa

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 6, 2019

if you still want to be removed, let me know, or close the PR if you're fine with continuing on :)

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Nov 7, 2019

Mhh, it looks it isn't a dependency anymore. spesmilo/electrum#4825 spesmilo/electrum@5df5aaa

Should we remove the whole fork then?

@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Nov 7, 2019

The electrum change hasn't been released yet. But after that I think we can remove , as it isn't used anywhere else jsonrpclib-pelix and modern alternatives exist for the package.

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 7, 2019

electron-cash also mentions it,

$ rg jsonrpclib-pelix
pkgs/top-level/python-packages.nix
2577:  jsonrpclib-pelix = callPackage ../development/python-modules/jsonrpclib-pelix {};

pkgs/applications/misc/electron-cash/default.nix
17:    jsonrpclib-pelix

pkgs/applications/misc/electrum/ltc.nix
27:    jsonrpclib-pelix

pkgs/applications/misc/electrum/default.nix
65:    jsonrpclib-pelix

pkgs/development/python-modules/jsonrpclib-pelix/default.nix
7:  pname = "jsonrpclib-pelix";
19:    homepage = https://pypi.python.org/pypi/jsonrpclib-pelix/;
@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Nov 7, 2019

:/ OK in that case please remove me after all please. :)

@jonringer jonringer merged commit b417fed into NixOS:master Nov 7, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Moredread Moredread deleted the Moredread:maintainer-removal branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.