Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manim: init at 0.1.10 #72886

Merged
merged 1 commit into from Feb 10, 2020
Merged

manim: init at 0.1.10 #72886

merged 1 commit into from Feb 10, 2020

Conversation

@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Nov 6, 2019

Motivation for this change

#60284

cc @ajs124 @matthew-piziak

Please try to use it. Should I add some documentation, to make clear, that it can only be run with manim example.py FooScene and not python -m manim example.py FooScene? (I'm not even sure if the latter works upstream, but they've got it in some documentation).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@JohnAZoidberg
Copy link
Member Author

@JohnAZoidberg JohnAZoidberg commented Nov 15, 2019

Any thoughts @ajs124 @matthew-piziak ?

@matthew-piziak
Copy link
Contributor

@matthew-piziak matthew-piziak commented Nov 15, 2019

How do I build this in a shell again? I got error: cannot auto-call a function that has an argument without a default value ('lib').

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 15, 2019

@matthew-piziak try:

nix-shell -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/20df42503d673eed8284dbb7f146a81dd8c82551.tar.gz -p manim
@JohnAZoidberg JohnAZoidberg force-pushed the JohnAZoidberg:manim branch from 20df425 to c6960f4 Nov 16, 2019
@JohnAZoidberg JohnAZoidberg merged commit f10e240 into NixOS:master Feb 10, 2020
15 checks passed
15 checks passed
manim on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
manim on x86_64-linux Success
Details
@JohnAZoidberg JohnAZoidberg deleted the JohnAZoidberg:manim branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.