Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denemo: add WrapGAppsHook #72903

Merged
merged 1 commit into from Nov 15, 2019
Merged

denemo: add WrapGAppsHook #72903

merged 1 commit into from Nov 15, 2019

Conversation

@kylesferrazza
Copy link
Member

@kylesferrazza kylesferrazza commented Nov 6, 2019

closes #52958

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kylesferrazza kylesferrazza requested a review from jtojnar Nov 15, 2019
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 15, 2019

Could you squash the commits? Otherwise LGTM.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 15, 2019

Though, while at it, could you also clean up the package a bit. gettext and pkgconfig should move to nativeBuildInputs as well.

closes #52958

remove wrapProgram in favor of gappsWrapperArgs
move gettext and pkgconfig to nativeBuildInputs
@kylesferrazza kylesferrazza force-pushed the kylesferrazza:fix-52958 branch from f47061f to 5f37370 Nov 15, 2019
@jtojnar jtojnar merged commit 4a3a31b into NixOS:master Nov 15, 2019
15 checks passed
15 checks passed
denemo on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
denemo on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 15, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.