Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protontricks: 1.2.5 -> 1.3 #72912

Merged
merged 1 commit into from Nov 7, 2019
Merged

protontricks: 1.2.5 -> 1.3 #72912

merged 1 commit into from Nov 7, 2019

Conversation

@MetaDark
Copy link
Contributor

MetaDark commented Nov 6, 2019

Motivation for this change

Upgrade protontricks to 1.3 (https://github.com/Matoking/protontricks/releases/tag/1.3)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@JohnAZoidberg

This comment has been minimized.

Copy link
Member

JohnAZoidberg commented Nov 7, 2019

Did you try it with a game?

@MetaDark

This comment has been minimized.

Copy link
Contributor Author

MetaDark commented Nov 7, 2019

@JohnAZoidberg I verified that protontricks picked up my existing patches for Just Cause 2. But I'll reset the wine prefix to verify that applying the patches still works.

@MetaDark

This comment has been minimized.

Copy link
Contributor Author

MetaDark commented Nov 7, 2019

@JohnAZoidberg Tested protontricks 8190 d3dcompiler_43 d3dx10 on a clean wine prefix and everything works as expected.

Copy link
Member

JohnAZoidberg left a comment

Great! :)

@aanderse aanderse merged commit a627c29 into NixOS:master Nov 7, 2019
15 checks passed
15 checks passed
protontricks on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
protontricks on x86_64-linux Success
Details
@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Nov 7, 2019

Thanks team! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.