Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chipsec: 1.4.1 -> 1.4.3 #72918

Closed
wants to merge 1 commit into from
Closed

Conversation

@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Nov 6, 2019

Motivation for this change

https://github.com/chipsec/chipsec/releases/tag/1.4.3

Things done

Tested with:

nix-build -A linuxPackages_latest.chipsec
sudo ./result/bin/chipsec_main
sudo ./result/bin/chipsec_util acpi table XSDT
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc myself

Copy link
Contributor

@redvers redvers left a comment

On compilation I see this:

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support

Thoughts on apparent deprecation?

@JohnAZoidberg
Copy link
Member Author

@JohnAZoidberg JohnAZoidberg commented Nov 19, 2019

Yeah... They're currently, piece by piece, updating it to support Python3.
Migration is not complete yet.
See: https://github.com/chipsec/chipsec/tree/1.4.3

Any modules under the modules.tools directory have not yet been fully validated to work with python3

@JohnAZoidberg JohnAZoidberg force-pushed the JohnAZoidberg:chipsec-143 branch from 5ba84cc to 7401425 Dec 22, 2019
@JohnAZoidberg
Copy link
Member Author

@JohnAZoidberg JohnAZoidberg commented Feb 9, 2020

Superseded by #79620

@JohnAZoidberg JohnAZoidberg deleted the JohnAZoidberg:chipsec-143 branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.