Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package metadata like version and homepage #72922

Merged
merged 1 commit into from Nov 11, 2019
Merged

Conversation

@davidak
Copy link
Member

davidak commented Nov 6, 2019

Motivation for this change

Fix issues repology reported, so they detect our package versions correctly.

With such changes we will have even more up-to-date packages and be the best distro :)

https://repology.org/repositories/graphs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/tools/misc/venus/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/emscripten-packages.nix Outdated Show resolved Hide resolved
@rnhmjoj
rnhmjoj approved these changes Nov 7, 2019
Copy link
Contributor

rnhmjoj left a comment

I'm reviewing my part (vapoursynth). Thanks, I didn't know the "R" wasn't part of the version.

@davidak davidak force-pushed the davidak:fix_versions branch from 07bad42 to 61de713 Nov 7, 2019
@davidak

This comment has been minimized.

Copy link
Member Author

davidak commented Nov 7, 2019

Thanks, I didn't know the "R" wasn't part of the version.

@rnhmjoj It is not used by most other distros, but it seems actually the official version.

https://repology.org/project/vapoursynth/versions
https://github.com/vapoursynth/vapoursynth/releases
http://www.vapoursynth.com/

It might be better fixed on repology to just ignore the R to better compare the versions. I reverted the change!

@davidak davidak requested a review from jtojnar Nov 7, 2019
@ofborg ofborg bot requested a review from rnhmjoj Nov 7, 2019
@jtojnar
jtojnar approved these changes Nov 7, 2019
@rnhmjoj

This comment has been minimized.

Copy link
Contributor

rnhmjoj commented Nov 7, 2019

but it seems actually the official version.

It seems so. Though I don't know how repology work.

@ehmry
ehmry approved these changes Nov 10, 2019
@jtojnar jtojnar merged commit e994fdc into NixOS:master Nov 11, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@davidak davidak deleted the davidak:fix_versions branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.