Skip to content

/nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing pypi package for tables #72930

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@merijnb
Copy link
Contributor

merijnb commented Nov 6, 2019

The package has vanished from pypi, and only this new version is now
available. The release notes for the new version state:

Release 3.6.1
Maintenance release to fix packaging issues.
No new features or bug fixes.

so I can only assume that the 3.6.0 release was not working correctly.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh @jonringer
@merijnb
Fix missing pypi package for tables
Loading status checks…
aaa2827 
The package has vanished from pypi, and only this new version is now
available. The release notes for the new version state:

```
Release 3.6.1
Maintenance release to fix packaging issues.
No new features or bug fixes.
```

so I can only assume that the 3.6.0 release was not working correctly.
@merijnb merijnb requested review from FRidh and jonringer as code owners Nov 6, 2019
@veprbl

This comment has been minimized.

Sign in to view
Copy link
Member

veprbl commented Nov 6, 2019

@GrahamcOfBorg build python37Packages.tables python38Packages.tables
@veprbl
veprbl approved these changes Nov 7, 2019
View changes
Copy link
Member

veprbl left a comment

nix-review (x86_64-linux, NixOS with sandboxing)

1 package are marked as broken and were skipped:
python37Packages.imgaug

23 package failed to build:
python37Packages.atomman python37Packages.blaze python37Packages.dask-ml python37Packages.dftfit python37Packages.google_cloud_bigquery python37Packages.hvplot python37Packages.ibis-framework python37Packages.imbalanced-learn python37Packages.intake python37Packages.lammps-cython python37Packages.mesa python37Packages.nipype python37Packages.odo python37Packages.optuna python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.rl-coach python37Packages.slicedimage python37Packages.starfish python37Packages.streamz python37Packages.sumo python37Packages.sunpy python37Packages.vega

56 package were build:
csvs-to-sqlite paperwork python37Packages.Quandl python37Packages.acoustics python37Packages.altair python37Packages.aplpy python37Packages.awkward python37Packages.bkcharts python37Packages.caffe python37Packages.cnvkit python37Packages.cufflinks python37Packages.dask python37Packages.dask-glm python37Packages.dask-image python37Packages.dask-jobqueue python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.datashader python37Packages.distributed python37Packages.drms python37Packages.fastparquet python37Packages.geopandas python37Packages.glymur python37Packages.google_cloud_monitoring python37Packages.histbook python37Packages.holoviews python37Packages.image-match python37Packages.osmnx python37Packages.pandas python37Packages.partd python37Packages.phik python37Packages.pims python37Packages.pvlib python37Packages.pyarrow python37Packages.pybids python37Packages.pyfftw python37Packages.pymc3 python37Packages.pytrends python37Packages.scikit-bio python37Packages.scikitimage python37Packages.seaborn python37Packages.statsmodels python37Packages.stumpy python37Packages.tables python37Packages.tablib python37Packages.trackpy python37Packages.uproot python37Packages.uproot-methods python37Packages.vega_datasets python37Packages.vidstab python37Packages.wrf-python python37Packages.xarray python37Packages.xgboost python38Packages.tables streamlit visidata

None of the failures appear to be due to this bump.
@veprbl veprbl self-assigned this Nov 7, 2019
@veprbl veprbl merged commit f3288a2 into NixOS:master Nov 7, 2019
16 checks passed
16 checks passed
python37Packages.tables, python38Packages.tables on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.tables, python38Packages.tables on aarch64-linux Success
Details
python37Packages.tables, python38Packages.tables on x86_64-linux Success
Details
@veprbl veprbl removed their assignment Nov 7, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 7, 2019
@merijnb @dtzWill
pythonPackages.tables: 3.6.0 -> 3.6.1 (NixOS#72930)
d57f429 
The package has vanished from pypi, and only this new version is now
available. The release notes for the new version state:

```
Release 3.6.1
Maintenance release to fix packaging issues.
No new features or bug fixes.
```

so I can only assume that the 3.6.0 release was not working correctly.

(cherry picked from commit f3288a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 6.topic: python 6.topic: reproducible builds
Projects
None yet
Milestone
No milestone
2 participants
@merijnb @veprbl
You can’t perform that action at this time.