Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsass: 3.6.1 -> 3.6.3 #72934

Closed
wants to merge 1 commit into from
Closed

libsass: 3.6.1 -> 3.6.3 #72934

wants to merge 1 commit into from

Conversation

@alyssais
Copy link
Member

alyssais commented Nov 6, 2019

cc @FRidh @hedning for testing with gtk+

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 7, 2019

3.6.2 got reverted though I think that issue got resolved.
sass/libsass#3006

@hedning

This comment has been minimized.

Copy link
Contributor

hedning commented Nov 7, 2019

Yeah, though this might be a new problem: sass/libsass#3033. Apparently building arc-theme takes tons of ram/time.

@lazka

This comment has been minimized.

Copy link

lazka commented Nov 8, 2019

Yeah, though this might be a new problem: sass/libsass#3033. Apparently building arc-theme takes tons of ram/time.

Same for the default gtk theme.

@alyssais alyssais closed this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.