Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin: fix adoptopenjdk-hotspot-bin-8 build #72950

Closed
wants to merge 1 commit into from

Conversation

@hlolli
Copy link
Member

hlolli commented Nov 6, 2019

Motivation for this change

On current master, running nix-build . -A adoptopenjdk-hotspot-bin-8 results in ln: failed to create symbolic link '/nix/store/fkhmgiyh6sh65x0x27wwlsz1m2nv5wrw-adoptopenjdk-hotspot-bin-8.0.222/jre': File exists.

Things done

I make sure that this backwards compatability mechanism isn't breaking builds on older jdk versions, by checking first if the directory exists (and hence the need for this ln -s call).

  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [ x ] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @taku0

@taku0
taku0 approved these changes Nov 7, 2019
Copy link
Contributor

taku0 left a comment

LGTM.
Tested on macOS.

@hlolli
Copy link
Member Author

hlolli commented May 16, 2020

I see this has been solved now differently, closing.

@hlolli hlolli closed this May 16, 2020
@hlolli hlolli deleted the hlolli:darwin/adoptopenjdk-bin-8-fix branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.