Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lego: 3.0.2 -> 3.1.0 #72952

Closed
wants to merge 1 commit into from
Closed

lego: 3.0.2 -> 3.1.0 #72952

wants to merge 1 commit into from

Conversation

@wizeman
Copy link
Member

@wizeman wizeman commented Nov 6, 2019

Motivation for this change

lego 3.0.2 won't build anymore because one of the go dependencies cannot be downloaded due to the commit being missing.

This should probably be backported to 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andrew-d

Copy link
Contributor

@andrew-d andrew-d left a comment

Looks like you've got a hash mismatch:

hash mismatch in fixed-output derivation '/nix/store/dmx51z9kdsd4cp3jc47ml7rm9sp8hz64-lego-3.1.0-go-modules':
  wanted: sha256:0jhhzwz0z8wg9a6y0r32vsigzxblzwqykjgkmwrik06kph0dz7dc
  got:    sha256:0k3p11cji3p4nzr8aia8hp01wyx1qfx84259dwbfwg1b32ln8rkc
pkgs/tools/admin/lego/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Contributor

@aanderse aanderse commented Nov 10, 2019

ping @wizeman

@wizeman wizeman force-pushed the wizeman:u/upd-lego branch from 9cd1fb0 to 0eab53f Nov 11, 2019
@wizeman
Copy link
Member Author

@wizeman wizeman commented Nov 11, 2019

I fixed the hash but note that the modSha256 I had previously was the one I got on the 19.09 branch.
I compared the downloaded dependencies and it seems that on 19.09 quite a few more dependencies get downloaded, which are the same packages but with different versions, e.g.:

(...)
 go: finding github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
 go: finding github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
 go: finding github.com/xeipuuv/gojsonschema v1.1.0
+go: finding golang.org/x/crypto v0.0.0-20180621125126-a49355c7e3f8
+go: finding golang.org/x/crypto v0.0.0-20180904163835-0709b304e793
+go: finding golang.org/x/crypto v0.0.0-20190211182817-74369b46fc67
+go: finding golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
+go: finding golang.org/x/crypto v0.0.0-20190418165655-df01cb2cc480
 go: finding golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4
 go: finding golang.org/x/exp v0.0.0-20190121172915-509febef88a4
+go: finding golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3
+go: finding golang.org/x/lint v0.0.0-20190227174305-5b3e6a55c961
+go: finding golang.org/x/lint v0.0.0-20190301231843-5614ed5bae6f
+go: finding golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3
 go: finding golang.org/x/lint v0.0.0-20190409202823-959b441ac422
(...)

I imagine this happens because 19.09 uses go 1.12 but master uses go 1.13, but I don't know for sure.
So I guess if this commit gets backported, the modSha256 hash must be changed.

@ofborg ofborg bot requested a review from andrew-d Nov 11, 2019
@bbigras
Copy link
Contributor

@bbigras bbigras commented Nov 25, 2019

Can this PR be updated to 3.2.0?

@bbigras bbigras mentioned this pull request Nov 27, 2019
7 of 10 tasks complete
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 4, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/77

@timokau
Copy link
Member

@timokau timokau commented Dec 5, 2019

Superseded by #74371.

@timokau timokau closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.