Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/awstats: drop module #72961

Closed
wants to merge 1 commit into from
Closed

nixos/awstats: drop module #72961

wants to merge 1 commit into from

Conversation

@aanderse
Copy link
Contributor

aanderse commented Nov 7, 2019

Motivation for this change

The awstats module has never been maintained after initially added to nixpkgs and should be removed, or have someone take ownership of it.

ping @vcunat @griff

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aristaeus

This comment has been minimized.

Copy link
Contributor

aristaeus commented Nov 9, 2019

I looked into setting up AWstats a few weeks ago, but after 5 minutes couldn't work out how to use this module. For example, there is no option to specify log locations - it seems like this module assumes you're only serving one website, and that website is using apache.

I was planning to roll my own solution - and have been umming and ahing about pushing it upstream. My main concern was breaking backwards compatibility - but if the alternative is removal then that probably isn't a problem.

So I'd be happy to take ownership of this and do some refactoring to make it more flexible.

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Nov 9, 2019

IIRC awstats started as a prototype written for @tohl, but I suspect it's never made it to practical usage. (And I won't be maintaining it.)

@aanderse

This comment has been minimized.

Copy link
Contributor Author

aanderse commented Nov 9, 2019

@aristaeus yeah the module isn't complete, makes far too many assumptions, and only works use under fairly limited scope.

I'd love to coordinate with you if you're rewriting this, as my motivation for this PR is changes I'm making to the httpd module. I'll ping you in my upcoming httpd PR.

Thank you!

@aanderse aanderse closed this Nov 9, 2019
@aanderse aanderse mentioned this pull request Nov 9, 2019
6 of 14 tasks complete
@tohl

This comment has been minimized.

Copy link
Contributor

tohl commented Nov 9, 2019

@griff

This comment has been minimized.

Copy link
Contributor

griff commented Nov 9, 2019

I also never used this module since I was only interested in the mail stats functionality of awstats which this module didn't support and so I have my own local module just for that. So I would be fine with the module being removed.

@griff

This comment has been minimized.

Copy link
Contributor

griff commented Nov 9, 2019

@aristaeus If you plan on also supporting mail stats or would be open to getting support for that into your new module I would love to help out with code and comments from my own hacked together module if it means I no longer have to maintain my own module.

@aristaeus

This comment has been minimized.

Copy link
Contributor

aristaeus commented Nov 10, 2019

@griff sounds good. Is your config online somewhere?

@griff

This comment has been minimized.

Copy link
Contributor

griff commented Nov 10, 2019

@aristaeus it is now mail-awstats.nix.

Please note that it is very hacky and only works for postfix and though there are options for multiple domains it only collects statistics for all the configured postfix domains combined. And if the journald log is very large the first time the hourly service is run it will be very slow because it reads the log twice.

@aanderse

This comment has been minimized.

Copy link
Contributor Author

aanderse commented Nov 22, 2019

@griff thanks for providing that! @aristaeus any updates on your progress?

@aristaeus

This comment has been minimized.

Copy link
Contributor

aristaeus commented Nov 23, 2019

@aanderse Sorry, I've had a busy couple of weeks. My branch is now looking pretty respectable so I'll submit a PR now.

@aristaeus aristaeus mentioned this pull request Nov 23, 2019
1 of 10 tasks complete
@aanderse

This comment has been minimized.

Copy link
Contributor Author

aanderse commented Nov 23, 2019

Great, thanks!

@aanderse aanderse deleted the aanderse:awstats branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.