Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruplacer: init at 0.4.1 #72971

Merged
merged 2 commits into from Nov 8, 2019
Merged

ruplacer: init at 0.4.1 #72971

merged 2 commits into from Nov 8, 2019

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@filalex77 filalex77 changed the title Ruplacer 0.4.1 ruplacer: init at 0.4.2 Nov 7, 2019
@filalex77 filalex77 changed the title ruplacer: init at 0.4.2 ruplacer: init at 0.4.1 Nov 7, 2019
@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Nov 7, 2019

@GrahamcOfBorg build ruplacer

@filalex77 filalex77 force-pushed the filalex77:ruplacer-0.4.1 branch from 42365b3 to ff129fd Nov 7, 2019
@filalex77 filalex77 force-pushed the filalex77:ruplacer-0.4.1 branch from ff129fd to 8bb7737 Nov 7, 2019
@filalex77

This comment has been minimized.

Copy link
Contributor Author

filalex77 commented Nov 7, 2019

@mmahut I fixed the MacOS Security thing. r?

@filalex77 filalex77 mentioned this pull request Nov 7, 2019
8 of 10 tasks complete
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 8, 2019

Checking Darwin build:
@GrahamcOfBorg build ruplacer

@c0bw3b
c0bw3b approved these changes Nov 8, 2019
Copy link
Contributor

c0bw3b left a comment

Builds and runs

Result of nix-review pr 72971 1

1 package were build:
  • ruplacer

$ ./results/ruplacer/bin/ruplacer --color always old new -- test.txt 
Patching test.txt
-- This is old
++ This is new

Would perform 1 replacement on 1 matching file
Re-run ruplacer with --go to write these changes to the filesystem
@c0bw3b c0bw3b merged commit ac8d850 into NixOS:master Nov 8, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ruplacer on aarch64-linux Success
Details
ruplacer on x86_64-darwin Success
Details
ruplacer on x86_64-linux Success
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
ruplacer: init at 0.4.1
(cherry picked from commit ac8d850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.