Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topgrade: init at 3.4.0 #72976

Merged
merged 2 commits into from Nov 19, 2019
Merged

topgrade: init at 3.4.0 #72976

merged 2 commits into from Nov 19, 2019

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@filalex77 filalex77 force-pushed the filalex77:topgrade-3.3.0 branch from 8d342e5 to 17c0b13 Nov 9, 2019
@filalex77 filalex77 marked this pull request as ready for review Nov 9, 2019
@Lassulus

This comment has been minimized.

Copy link
Contributor

Lassulus commented Nov 17, 2019

sadly I get this error:

hash mismatch in fixed-output derivation '/nix/store/np899m2ffgry6l8s1rg82wp2w9fij50g-topgrade-3.3.0-vendor':
  wanted: sha256:0nwhv7j2wbzh6h4jrxsgcyvqi4sj021k74myj5y44asignacvx3i
  got:    sha256:1fpmd4ykczcg830n2mmikcgnzlcfms9ay0yjan37y877bhi9bkh0
cannot build derivation '/nix/store/m1vy5ksc8gcl38lyv6hybylkwfmgr3z1-topgrade-3.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zhsyazyq0x4a1ygcxyib54hifsf94lbr-env.drv': 1 dependencies couldn't be built
Copy link
Member

ryantm left a comment

Fix build

@filalex77 filalex77 requested a review from ryantm Nov 19, 2019
@filalex77 filalex77 changed the title topgrade: init at 3.3.0 topgrade: init at 3.4.0 Nov 19, 2019
Copy link
Contributor

Lassulus left a comment

tested with nix-review, updated my emacs profile with it, (sadly nix didn't work, but thats probably on me)

@Lassulus Lassulus merged commit ae9846c into NixOS:master Nov 19, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
topgrade on aarch64-linux Success
Details
topgrade on x86_64-linux Success
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 19, 2019
* topgrade: init at 3.4.0

(cherry picked from commit ae9846c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.