Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.vim-metamath: init at 2019-11-07 #72990

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@Taneb
Copy link
Contributor

Taneb commented Nov 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Taneb Taneb requested a review from jonringer as a code owner Nov 7, 2019
@ofborg ofborg bot added the 6.topic: vim label Nov 7, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 7, 2019

I just merged an update a few minutes a go, do you mind rebasing, and then following https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs

you should have an update commit, then adding your package + another update

@Taneb

This comment has been minimized.

Copy link
Contributor Author

Taneb commented Nov 7, 2019

Yes, sure. I'd misread the instructions, I'm afraid.

@Taneb Taneb force-pushed the Taneb:vim-metamath branch from d60711e to df29090 Nov 7, 2019
@Taneb

This comment has been minimized.

Copy link
Contributor Author

Taneb commented Nov 7, 2019

@jonringer I've updated the PR

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM

[38 built, 1 copied, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72990
20 package were build:
vimPlugins.ale vimPlugins.antonys-macro-repeater vimPlugins.coc-lists vimPlugins.coc-python vimPlugins.coc-tsserver vimPlugins.ctrlp-vim vimPlugins.denite-nvim vimPlugins.ghcid vimPlugins.iceberg-vim vimPlugins.ncm2-ultisnips vimPlugins.neosnippet-vim vimPlugins.neoterm vimPlugins.ultisnips vimPlugins.vim-lsc vimPlugins.vim-metamath vimPlugins.vim-pandoc vimPlugins.vim-snippets vimPlugins.vim-visual-multi vimPlugins.vimtex vimPlugins.zig-vim

weird that antonys-macro-repeater was added, but I don't think that was related to this PR

@jonringer jonringer merged commit 31315ec into NixOS:master Nov 7, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vimPlugins.vim-metamath on aarch64-linux Success
Details
vimPlugins.vim-metamath on x86_64-linux Success
Details
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 7, 2019

no problem :), thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.