Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

sclack: init at unstable-2019-07-15 #72994

Draft
wants to merge 3 commits into
base: master
from
Draft

sclack: init at unstable-2019-07-15 #72994

wants to merge 3 commits into from

Conversation

@evanjs
Copy link
Member

evanjs commented Nov 7, 2019

Motivation for this change

#59900 -- add sclack package
Stumbled across this issue and hadn't heard of sclack before.
Works pretty well, especially compared to e.g. slack-term.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TODO

  • config.json
    • I'm just copying over the default config.json, is this enough? Or should this have a module with extraConfig, etc? Maybe configuring this option could be deferred to home-manager, etc.
  • Mac Support
    • While urwid lists support for linux and darwin, urwid_readline only lists support for linux. Can a darwin user confirm whether this works on mac?
  • app.py
    • Is there a cleaner way to install the executable (vs moving app.py to sclack)?
  • asyncio
    • @exarkun recommended filing a bug upstream since asyncio should be a conditional dependency. Which is still odd to me as the repo requires 3.4+ anyway... Should I block on that and leave my workaround in if the author declines? Or is there a better way to handle it here, anyway?
  • emoji
    • emoji don't seem to work right away, do we need to do something with fontconfig, or at least provide a font option, etc? This seems to be the case for only a few emoji, e.g. 馃し鈥嶁檪, most emoji seem to work fine.
    • sclack - Nerd Fonts

I think that's it, but I'm happy to address anything else I missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.