Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.geary: add patch for longer client test timeout #72998

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Nov 7, 2019

Motivation for this change

I'm see this test timeout frequently, most often on aarch64 on hydra.
Patch is from debian, which probably noticed the same issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

I'm see this test timout frequently, most often on aarch64 on hydra.
Patch is from debian, which probably noticed the same issue.
@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Nov 7, 2019

Michael Gratton is the upstream developer. Is not there an in-tree patch we could use?

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 7, 2019

Michael Gratton is the upstream developer. Is not there an in-tree patch we could use?

Don't think so

Perhaps the goal was to have

which gives all the tests more time to run.

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Nov 7, 2019

Aargh, I would expect Debian to be better. At least add mention a patch source.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 8, 2019

@worldofpeace worldofpeace merged commit b859c85 into NixOS:master Nov 8, 2019
16 checks passed
16 checks passed
gnome3.geary on x86_64-darwin No attempt
Details
gnome3.geary on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
gnome3.geary on aarch64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace worldofpeace deleted the worldofpeace:client-tests-geary branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.