Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncmpc: 0.35 -> 0.36 #73000

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@phi-gamma
Copy link
Contributor

phi-gamma commented Nov 7, 2019

New release fixing a crash that affects nixos due to the build without
pcre. https://github.com/MusicPlayerDaemon/ncmpc/releases/tag/v0.36

Motivation for this change

Upstream released a new version fixing a flaw that affects nixos in particular.

Things done

Functionality testing on 19.09.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

New release fixing a crash that affects nixos due to the build without
pcre. https://github.com/MusicPlayerDaemon/ncmpc/releases/tag/v0.36
@fpletz
fpletz approved these changes Nov 8, 2019
Copy link
Member

fpletz left a comment

Thanks! Will also backport to 19.09.

@fpletz fpletz merged commit 5aed8a9 into NixOS:master Nov 8, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ncmpc on aarch64-linux Success
Details
ncmpc on x86_64-linux Success
Details
@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Nov 8, 2019

Oh, I just realized we have 0.34 in 19.09. Do you know if this bug also affects 0.34?

@phi-gamma

This comment has been minimized.

Copy link
Contributor Author

phi-gamma commented Nov 8, 2019

Do you know if this bug also affects 0.34?

At least the spurious assert which caused the uninitialized access
was there in 0.34. I’m also certain the issue is present with the
ncmpc in 19.03 and 19.09 because I kept being annoyed by it. ;-)

@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Nov 8, 2019

Thanks! Backporting... 😃

@phi-gamma

This comment has been minimized.

Copy link
Contributor Author

phi-gamma commented Nov 8, 2019

Thanks! Will also backport to 19.09.

What version of mpd does 19.09 ship? I’ve had issues running
v0.36 against the mpd in 19.03 due to an API mismatch. IIRC the
“tagtypes” query doesn’t support arguments in older mpd versions,
but ncmpc is using that query as of v0.36. I can confirm that the mpd
from nixpkgs master works fine though.

I’m not on nixos right now (work) so I can’t check myself.

@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Nov 8, 2019

Hmm, weird, we seem to have mpd 0.20.23 on master, 19.09 and even 19.03.

@phi-gamma

This comment has been minimized.

Copy link
Contributor Author

phi-gamma commented Nov 8, 2019

Was the mpd in 19.03 backported?

More specifically, we need this commit:
MusicPlayerDaemon/MPD@29453ba

@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Nov 8, 2019

There doesn't seem to have been any bumps of mpd since December 2018. So no backport to 19.03.

Okay, in that case I'll better revert the ncmpc bump for now on 19.09. We definitely don't want to bump mpd on the stable branches to 0.21 or apply that patch as it adds a new feature.

Thanks a lot for the explanations and the research! We should bump mpd on master soon. :)

@phi-gamma phi-gamma mentioned this pull request Nov 9, 2019
0 of 6 tasks complete
@phi-gamma

This comment has been minimized.

Copy link
Contributor Author

phi-gamma commented Nov 9, 2019

in that case I'll better revert the ncmpc bump for now on 19.09. We definitely don't want to bump mpd on the stable branches to 0.21 or apply that patch as it adds a new feature.

How about just adding the patch then? It’s a one line fix.

We should bump mpd on master soon.

Agreed, #73112 !

pacien added a commit to pacien/nixpkgs that referenced this pull request Nov 16, 2019
ncmpc 0.36 isn't compatible with mpd 0.20 which is the version packaged on
the release-19.09 branch.

See NixOS#73000 (comment).

This reverts commit 245f5ec.
@pacien pacien mentioned this pull request Nov 16, 2019
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.