Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: 1.6.2 -> 1.6.3 #73016

Closed
wants to merge 3 commits into from
Closed

podman: 1.6.2 -> 1.6.3 #73016

wants to merge 3 commits into from

Conversation

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Nov 8, 2019

Motivation for this change

The slirp4netns change is needed for proper rootless containers to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@jonringer jonringer left a comment

do you mind changing the outputs of podman to:

outputs = [ "out" "man" ];

nothing actually gets written to the outPath but:

$ tree ./result
./result
└── nix-support
    └── propagated-build-inputs

1 directory, 1 file
[00:34:06] jon@jon-desktop /home/jon/projects/nixpkgs (fix-isort)
$ realpath ./result
/nix/store/dp6gv8r80rycxx4ryzf8w1v6v093jygx-podman-1.6.3
@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Nov 8, 2019

WIP
@ofborg ofborg bot requested review from ehmry, vdemeester and saschagrunert Nov 12, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 12, 2019

I think there's debug symbols pointing back to the compiler, if you grep the binary, you will find a store path to go

Copy link
Member

@saschagrunert saschagrunert left a comment

I think there is a man page missing from this release. The commit containers/podman@079164c is not part of v1.6.3. Does this hurt us?


stdenv.mkDerivation rec {
pname = "slirp4netns";
version = "0.3.0";
version = "0.4.2";

This comment has been minimized.

@saschagrunert

saschagrunert Nov 12, 2019
Member

I hm as an update already in progress here: #67692

Which one do we want to pick?

@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Jan 13, 2020

1.7.0 is already in master.

@peterhoeg peterhoeg closed this Jan 13, 2020
@peterhoeg peterhoeg deleted the peterhoeg:u/podman branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.