Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haproxy: 1.9.8 -> 2.0.8 #73017

Merged
merged 2 commits into from Nov 9, 2019
Merged

haproxy: 1.9.8 -> 2.0.8 #73017

merged 2 commits into from Nov 9, 2019

Conversation

@peterhoeg
Copy link
Member

peterhoeg commented Nov 8, 2019

Motivation for this change

New LTS release.

Also add support for the builtin prometheus exporter, so we don't have to use an external service.

The nixos test doesn't complete but currently on unstable all nixos tests are broken...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fuzzy-id

@peterhoeg peterhoeg force-pushed the peterhoeg:u/haproxy branch from 356e76c to c4f7bf9 Nov 8, 2019
Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
executable shows usage

[3 built, 1 copied (1.5 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73017
1 package were build:
haproxy
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 8, 2019

@GrahamcOfBorg test haproxy

@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Nov 9, 2019

nix-review happy, macos 10.13

@jonringer jonringer merged commit 954e234 into NixOS:master Nov 9, 2019
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haproxy on aarch64-linux Success
Details
haproxy on x86_64-linux Success
Details
tests.haproxy on aarch64-linux Success
Details
tests.haproxy on x86_64-linux Success
Details
@peterhoeg peterhoeg deleted the peterhoeg:u/haproxy branch Nov 10, 2019
@peterhoeg peterhoeg restored the peterhoeg:u/haproxy branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.