Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.isort: fix tests #73026

Closed
wants to merge 1 commit into from
Closed

Conversation

@jonringer
Copy link
Contributor

jonringer commented Nov 8, 2019

Motivation for this change

noticed it was broken on hydra due to timeout https://hydra.nixos.org/build/104639574

I believe something with the sub shell was causing it to hang

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner Nov 8, 2019
@ofborg ofborg bot added the 6.topic: python label Nov 8, 2019
@ofborg ofborg bot requested a review from couchemar Nov 8, 2019
@couchemar

This comment has been minimized.

Copy link
Contributor

couchemar commented Nov 9, 2019

looks good for me

@d-goldin

This comment has been minimized.

Copy link
Contributor

d-goldin commented Nov 19, 2019

LGTM. Compiles, tests, runs for me.
With this amount of dependants, maybe staging?

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 19, 2019

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 19, 2019

closing for now, if hydra hangs again, I'll re-open

@jonringer jonringer closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.