Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boxfort: unstable-2019-09-19 -> unstable-2019-10-09 #73037

Merged
merged 1 commit into from Oct 25, 2020

Conversation

@Yumasi
Copy link
Contributor

@Yumasi Yumasi commented Nov 8, 2019

An update to the latest BoxFort version. This switches the build system to meson, and fixes a bug with the latest versions of gdb preventing its use for debugging Criterion unit tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Thesola10

Copy link
Contributor

@Thesola10 Thesola10 left a comment

Tested locally on Arch+Nix, criterion works with it, looks good to me

@Thesola10
Copy link
Contributor

@Thesola10 Thesola10 commented Nov 8, 2019

Just did local tests on Arch+Nix, you can check "Built packages that depend on" and "Tested on other Linux" then

@risicle
Copy link
Contributor

@risicle risicle commented Nov 9, 2019

Builds on macos 10.13

pkgs/development/libraries/boxfort/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/boxfort/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/boxfort/default.nix Outdated Show resolved Hide resolved
@Yumasi Yumasi force-pushed the criterion-unstable-191009 branch from 7b4284b to d3cf716 Nov 18, 2019
@Yumasi
Copy link
Contributor Author

@Yumasi Yumasi commented Nov 18, 2019

Thanks @Thesola10 @jtojnar and @risicle for your reviews !

@ofborg ofborg bot requested a review from Thesola10 Nov 18, 2019
Copy link
Contributor

@Thesola10 Thesola10 left a comment

Yep, looks about right!

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 10, 2020

needs rebase

Signed-off-by: Guillaume Pagnoux <guillaume.pagnoux@lse.epita.fr>
@Yumasi Yumasi force-pushed the criterion-unstable-191009 branch from d3cf716 to 5c1daeb Feb 11, 2020
@ofborg ofborg bot requested a review from Thesola10 Feb 11, 2020
@stale
Copy link

@stale stale bot commented Sep 30, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 25, 2020

Result of nixpkgs-review pr 73037 1

2 packages built:
- boxfort
- criterion

@bhipple bhipple merged commit fdba3f6 into NixOS:master Oct 25, 2020
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants