Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epr: init at 2.3.0b #73038

Merged
merged 2 commits into from Nov 9, 2019
Merged

epr: init at 2.3.0b #73038

merged 2 commits into from Nov 9, 2019

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

pkgs/applications/misc/epr/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/epr/default.nix Outdated Show resolved Hide resolved
@filalex77 filalex77 force-pushed the filalex77:epr-2.3.0b branch from 814461f to 944945b Nov 9, 2019
Co-authored-by: zimbatm <zimbatm@users.noreply.github.com>
@filalex77 filalex77 requested a review from zimbatm Nov 9, 2019
@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Nov 9, 2019

Seems to WFM, macos 10.13

@zimbatm zimbatm merged commit 7cdd581 into NixOS:master Nov 9, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
epr on aarch64-linux Success
Details
epr on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
* epr: init at 2.3.0b

* Apply changes from code review

Co-authored-by: zimbatm <zimbatm@users.noreply.github.com>
(cherry picked from commit 7cdd581)
@filalex77 filalex77 deleted the filalex77:epr-2.3.0b branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.