Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fselect: init at 0.6.6 #73044

Closed
wants to merge 1 commit into from
Closed

fselect: init at 0.6.6 #73044

wants to merge 1 commit into from

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

pkgs/tools/misc/fselect/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/fselect/default.nix Outdated Show resolved Hide resolved
@filalex77 filalex77 mentioned this pull request Nov 9, 2019
@filalex77 filalex77 force-pushed the filalex77:fselect-0.6.6 branch from 3bad022 to 3daf6b6 Nov 11, 2019
@filalex77 filalex77 closed this Nov 11, 2019
@filalex77 filalex77 deleted the filalex77:fselect-0.6.6 branch Nov 11, 2019
@filalex77

This comment has been minimized.

Copy link
Contributor Author

filalex77 commented Nov 11, 2019

Closed in favor of #73206.

Changes:

  • added myself as a maintainer
  • updated to 0.6.7
  • removed the patch (Cargo.lock added upstream in jhspetersson/fselect#61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.