Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.crypto-commons: init at unstable-2019-11-08 #73069

Closed
wants to merge 1 commit into from

Conversation

@Pamplemousse
Copy link
Member

Pamplemousse commented Nov 8, 2019

Motivation for this change

Make the awesome p4-team/crypto-commons available for CTF players using NixOS!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
@Pamplemousse

This comment has been minimized.

Copy link
Member Author

Pamplemousse commented Nov 8, 2019

Opened an issue in the upstream repo to know under which license this Python package is available.

@Pamplemousse Pamplemousse force-pushed the Pamplemousse:crypto_commons branch from 0688c46 to d1a66b5 Nov 8, 2019
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:crypto_commons branch from d1a66b5 to ab98be7 Nov 8, 2019
Copy link
Contributor

jonringer left a comment

I'm kind of on the fence on whether this should be added to nixpkgs...

no tests
no license
no releases
mostly done by 2 people....

Leaning toward NUR being a better location for this.

buildPythonPackage rec {
pname = "crypto-commons";
version = "unstable-2019-11-08";

This comment has been minimized.

Copy link
@jonringer

jonringer Nov 8, 2019

Contributor
Suggested change
};

checkInputs = [ gmpy2 ];

This comment has been minimized.

Copy link
@jonringer

jonringer Nov 8, 2019

Contributor
Suggested change
# repository doesn't include tests
doCheck = false;
};

checkInputs = [ gmpy2 ];

This comment has been minimized.

Copy link
@jonringer

jonringer Nov 8, 2019

Contributor

because there's no tests, at least verify you can import it correctly.

Suggested change
pythonImportsCheck = [
"crypto_commons.generic"
"crypto_commons.rsa.rsa_commons"
];
@Pamplemousse

This comment has been minimized.

Copy link
Member Author

Pamplemousse commented Nov 9, 2019

Ah, I think you are right: this package does not have to be in nixpkgs.
I had never heard of NUR, I am giving it a go now :)

@Pamplemousse Pamplemousse deleted the Pamplemousse:crypto_commons branch Nov 9, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 9, 2019

thank you for understanding :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.