Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dictances: init at 1.5.0 #73079

Closed
wants to merge 1 commit into from

Conversation

@Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Nov 8, 2019

Motivation for this change

Make this package is available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
@Pamplemousse Pamplemousse requested review from FRidh and jonringer as code owners Nov 8, 2019
@Pamplemousse Pamplemousse changed the title python3Packages.distances: init at 1.5.0 [WIP] python3Packages.dictances: init at 1.5.0 Nov 8, 2019
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:distances branch from 3c2aab1 to 82c6d64 Nov 8, 2019
@Pamplemousse Pamplemousse changed the title [WIP] python3Packages.dictances: init at 1.5.0 python3Packages.dictances: init at 1.5.0 Nov 8, 2019
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:distances branch from 82c6d64 to f812aad Nov 8, 2019
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:distances branch from f812aad to 071766c Nov 9, 2019
@Pamplemousse Pamplemousse requested review from risicle and jonringer Nov 13, 2019
};

# Missing some nixpkgs
doCheck = false;

This comment has been minimized.

@jonringer

jonringer Nov 13, 2019
Contributor

I would still like to see some tests, they are really important to demonstrate that a package isn't broken when it's dependencies get bumped.... although I guess this package doesn't really have any direct dependencies :)

Still would be nice :D

@Pamplemousse Pamplemousse deleted the Pamplemousse:distances branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.